Re: [PATCH 0/5] MR636: vkd3d-shader/fx: Add initial support for writing buffers descriptions.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/fx.c:
> static int hlsl_fx_5_write(struct hlsl_ctx *ctx, struct vkd3d_shader_code *out)
>  {
>      struct vkd3d_bytecode_buffer buffer = { 0 };
> - struct fx_write_context fx;
> uint32_t size_offset, size;
> -
>
> struct fx_write_context fx;
>
> fx_write_context_init(ctx, &fx_4_ops, &fx);
>
> put_u32(&fx.unstructured, 0); /* Empty string placeholder. */
> - /* TODO: buffers */
> - write_buffers(&fx);

BTW, superficially it looks like as if code could be shared between `hlsl_fx_4_write()` and `hlsl_fx_5_write()`.