On Fri Oct 25 15:54:39 2024 +0000, Matteo Bruni wrote:
If I understand the patches in the branch correctly, you're basically deferring conversion to `D3DXLoadSurface*()` time, which all in all seems nicer to me. I tried to look for anything breaking with the new approach (e.g. I was wondering about `D3DXCreateTextureFromFileInMemoryEx()` - it should be fine since it already takes the format from `d3dximage_info_from_d3dx_image()`) but I couldn't immediately find anything and, in general, tests should help with that concern. I have some specific questions on a couple details, but those are probably better reserved to the actual MR :smile:
Yes, the general idea is to do the conversion at the time of loading the volume/texture/surface instead of doing an extra conversion. It's possible that that could cause some confusion due to the `D3DXIMAGE_INFO` structure containing a different format than the `struct d3dx_image`, but I don't think that should be a huge issue.
I've opened a new [MR](https://gitlab.winehq.org/wine/wine/-/merge_requests/6746) with the first part of these patches, going to go ahead and close this one.