Re: [PATCH v10 0/4] MR8478: cfgmgr32: Device query API part 2: Implement object properties and initial device enumeration in DevCreateObjectQuery

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/cfgmgr32/tests/cfgmgr32.c:
> - {
> -
>    const DEV_OBJECT *obj = &objects[i];
> -
> -
>    winetest_push_context( "objects[%lu]", i );
> -
>    todo_wine ok_( __FILE__, line )( obj->cPropertyCount == 1, "got cPropertyCount %lu != 1\n",
> -
>                                     obj->cPropertyCount );
> -
>    todo_wine ok_( __FILE__, line )( !!obj->pProperties, "got pProperties %p\n", obj->pProperties );
> -
>    if (obj->pProperties)
> -
>        ok_( __FILE__, line )( IsEqualDevPropKey( obj->pProperties[0].CompKey.Key, exp_props[0].key ),
> -
>                               "got property {%s, %#lx} != {%s, %#lx}\n",
> -
>                               debugstr_guid( &obj->pProperties[0].CompKey.Key.fmtid ),
> -
>                               obj->pProperties[0].CompKey.Key.pid, debugstr_guid( &exp_props[0].key.fmtid ),
> -
>                               exp_props[0].key.pid );
> -
>    winetest_pop_context();
> - }
> - DevFreeObjects( buf_len, objects );

I still don't see how these additional tests are useful to run on every DEV_OBJECT enumerated by the caller. The inner `obj` variable even shadows the `obj` parameter, so it's obviously unused.