Re: [PATCH v11 0/1] MR7288: winegstreamer: Avoid large buffer pushes in wg_transform.

[Brendan McGrath (＠redmcg)]

On Wed Mar  5 01:20:21 2025 +0000, Brendan McGrath wrote:
> I just tried to build this in a container running debian bullseye and
> got the following error:
> ../../dlls/winegstreamer/wg_transform.c:68:50: error: expected ')'
> before string constant
>    68 | GST_ELEMENT_REGISTER_DEFINE(winegstreamerstepper,
> "winegstreamerstepper", GST_RANK_NONE, GST_TYPE_WG_STEPPER);
>       |                                                  ^~~~~~~~~~~~~~~~~~~~~~~
>       |                                                  )
>
> I _think_ that's because bullseye is running gstreamer version 1.18,
> whilst the documentation suggests `GST_ELEMENT_REGISTER_DEFINE` was
> added version 1.20.
> I think we'll need to address this as I _think_ Crossover is built
> against bullseye.

I was able to resolve this by copying the defines to our code (and declaring them if GStreamer version is < 1.20):

[winegstreamer.patch](/uploads/caf23dfb5e167f828b2709b17eb519fb/winegstreamer.patch)

I'm not sure that's the way we want to go; but I'll raise an MR with that (and I'll close it if there's a better option).