27 Jan
2025
27 Jan
'25
5:40 p.m.
On Mon Jan 27 16:47:20 2025 +0000, Huw Davies wrote:
Agreed.
Strongly disagree. The current implementation is virtually unintelligible.
dlls/oleaut32: Simplify loop in ITypeLib2_Constructor_MSFT() is suitable change on its own merit. dlls/oleaut32: Add DeleteTypeInfo() base-cases in typelib.c Agree it needs test cases, I have some locally.
While not all the changes are needed, however ref counting in this implementation looks very broken, there is variable re-uses that opens the door to use-after-frees and a number of other distasteful things.
For how simple the conceptual state machine is, the whole thing is virtually impossible to contribute to for any outsider in it's current form. Therefore some work is needed to lower the bar some.