Re: [PATCH v9 0/10] MR4982: Load and play MIDI

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/dmime/midi.c:
> - return S_OK;
>
> +}
> -
>
> +static const IPersistStreamVtbl midi_sequence_track_persiststream_vtbl =
> +{
> - dmobj_IPersistStream_QueryInterface,
> - dmobj_IPersistStream_AddRef,
> - dmobj_IPersistStream_Release,
> - dmobj_IPersistStream_GetClassID,
> - unimpl_IPersistStream_IsDirty,
> - track_IPersistStream_Load,
> - unimpl_IPersistStream_Save,
> - unimpl_IPersistStream_GetSizeMax,
>
> +};
> -
>
> +HRESULT create_midiseqtrack(REFIID riid, void **ppobj)

When considering this commit alone, this is still not called anywhere so all of this is dead code. You need to introduce something that uses these stubs at the same time or before they are added.

In this particular case, you could probably split the MIDI parsing commit, introduce the file parser helper first, add these stubs in a separate commit (instantiating the tracks from the parser), and implementing track parsing in a third one for instance.