On Sun Nov 20 09:07:06 2022 +0000, David Kahurani wrote:
changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/1199/diffs?diff_id=19801&start_sha=1ecd728a003508b7774886d473b6e3c06698f69d#0af299b5acebd553d56757f20ddaf3598bd74a7d_1963_2015)
Are there any more changes you would like to done to this? I think all the issues are resolved.
WriteString and WriteChars behave in an identical way. The same goes for WriteRaw and WriteRawChars. The only difference is the handling of an empty string which causes the closing of a start tag in WriteString and WriteRaw but not for WriteChars and WriteRawChars. I have not included tests that demonstrate this similarity because I find this will just be duplicating code(for instance, WriteChars passes all the WriteString tests with two exceptions). And, well, I have a feeling that this should be obvious to someone who works on/with these two functions. The tests for surrogates have been distributed to all four functions trying to make sure that an incorrect change to the code will break some tests in one of the four functions.