On Wed Aug 28 05:41:01 2024 +0000, Rémi Bernon wrote:
I don't think we should keep the new default if it's been changed recently, it wasn't really intentional. I've made some changes to restore the original behavior.
The new patch behaves more like I would expect, thanks! Could you please update the commit message to say that EnableShell is only on by default for the "shell" desktop? It would also be a good idea to put the line `Fixes: 118810ad3bac91bfeea81e4408059d48c158e8c5` at the bottom to let @mstefani know that the patch should probably be backported to Wine Stable.
The one weird thing I noticed is that with your patch, ShowSystray=0 prevents icons from appearing in the host taskbar (though it does not hide them in Wine's taskbar). That is a novel behavior not found in any previous version of Wine. I'm thinking that it would be best to keep the ShowSystray option restricted to controlling the floating systray. ShowSystray=0 would continue to support the use case where the user wants the pre-9.0 behavior: Display systray icons if there is a taskbar available, but hide them if they would have to be in a floating window. Later on we can add support for the NoTrayItemsDisplay registry setting that Windows has, which would be like ShowSystray but would hide the icons from the host taskbar and the Wine traskbar in addition to hiding the floating systray.