Re: [PATCH 0/5] MR581: d3d8, d3d9: More tests for dirty rects and UpdateTexture().

[Zebediah Figura (she/her)]

On 8/8/22 04:29, Francois Gouget (@fgouget) wrote:
> On Wed Aug  3 17:05:02 2022 +0000, **** wrote:
> > Marvin replied on the mailing list:
> > Hi,
> > It looks like your patch introduced the new failures shown below.
> > Please investigate and fix them before resubmitting your patch.
> > If they are not new, fixing them anyway would help a lot. Otherwise
> > please ask for the known failures list to be updated.
> > The tests also ran into some preexisting test failures. If you know how
> > to fix them that would be helpful. See the TestBot job for the details:
> > The full results can be found at:
> > https://testbot.winehq.org/JobDetails.pl?Key=120466
> > Your paranoid android.
> > === w8 (32 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w8adm (32 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w864 (32 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w1064v1507 (32 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w1064v1809 (32 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w1064 (32 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w1064_tsign (32 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w10pro64 (32 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w864 (64 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w1064v1507 (64 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w1064v1809 (64 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w1064 (64 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w1064_2qxl (64 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > device.c:14775: Test failed: Adapter 1: Expect window rect
> > (1024,0)-(2304,800), got (0,0)-(1280,800).
> > === w1064_adm (64 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w1064_tsign (64 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w10pro64 (64 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w10pro64_en_AE_u8 (64 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w10pro64_ar (64 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w10pro64_ja (64 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === w10pro64_zh_CN (64 bit report) ===
> > d3d9:
> > device.c:11937: Test failed: Got unexpected hr 0x88760868.
> > device.c:11942: Test failed: Got unexpected hr 0x88760868.
> > device.c:11944: Test failed: Got unexpected hr 0x88760869.
> > device.c:11946: Test failed: Got unexpected hr 0x8876086c.
> > === debian11 (64 bit WoW report) ===
> > d3d9:
> > device: Timeout
>
> The D3DERR_DEVICELOST (0x88760868) and D3DERR_INVALIDCALL (0x8876086c) failures are indeed new. D3DERR_NOTAVAILABLE (0x88760869) happened a few times in WineTest (20) but always followed a window message failure unlike here.
> So this patch needs fixing.

Indeed. Sorry I didn't notice these; the testbot failures are hard to 
see now that they go to a different list.