Re: [PATCH v6 0/8] MR717: Implement application hives in the registry

[Etaash Mathamsetty (＠etaash.mathamsetty)]

Etaash Mathamsetty (@etaash.mathamsetty) commented about dlls/ntdll/unix/registry.c:
> -
>          NtLoadKey  (NTDLL.@)
>
> */
>  NTSTATUS WINAPI NtLoadKey( const OBJECT_ATTRIBUTES *attr, OBJECT_ATTRIBUTES *file )
> +{
> - TRACE("(%p,%p)", attr, file);
> - return NtLoadKeyEx(attr, file, 0, 0, 0, 0, NULL, NULL);
>
> +}
> -
>
> +/******************************************************************************
> -
> -
>          NtLoadKey2  (NTDLL.@)
> - */
>
> +NTSTATUS WINAPI NtLoadKey2( const OBJECT_ATTRIBUTES *attr, OBJECT_ATTRIBUTES *file, ULONG flags )
> +{
> - if (flags) FIXME("unhandled flag REG_NO_LAZY_FLUSH");

1. I am pretty sure FIXME and TRACE require \n to go to the next line
2. Instead of saying FIXME("unhandled flag REG_NO_LAZY_FLUSH"), instead do FIXME("unhandled flags %x\n", flags), in the unlikely case that flags other than REG_NO_LAZY_FLUSH can be passed