[PATCH v2 1/2] mfreadwrite/tests: Add more tests for MFCreateSinkWriterFromURL.

[Ziqing Hui]

From: Ziqing Hui

---
 dlls/mfreadwrite/tests/mfplat.c | 70 +++++++++++++++++++++++++++++----
 1 file changed, 62 insertions(+), 8 deletions(-)

diff --git a/dlls/mfreadwrite/tests/mfplat.c b/dlls/mfreadwrite/tests/mfplat.c
index 41b2a033a59..87fdd917697 100644
--- a/dlls/mfreadwrite/tests/mfplat.c
+++ b/dlls/mfreadwrite/tests/mfplat.c
@@ -1415,19 +1415,71 @@ done:
     DestroyWindow(window);
 }

-static void test_sink_writer(void)
+static void test_sink_writer_create(void)
 {
+    WCHAR tmp_file[MAX_PATH];
     IMFSinkWriter *writer;
+    IMFByteStream *stream;
+    IMFAttributes *attr;
+    unsigned int i;
     HRESULT hr;

-    hr = MFCreateSinkWriterFromURL(NULL, NULL, NULL, NULL);
-    ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr);
+    struct create_sink_writer_from_url_test
+    {
+        const WCHAR *url;
+        IMFByteStream **stream;
+        IMFAttributes **attr;
+        IMFSinkWriter **writer;
+        HRESULT hr;
+    } create_sink_writer_from_url_tests[] =
+    {
+        {NULL,     NULL,    NULL,  NULL,    E_INVALIDARG},
+        {NULL,     NULL,    NULL,  &writer, E_INVALIDARG},
+        {NULL,     NULL,    &attr, &writer, E_INVALIDARG},
+        {NULL,     &stream, NULL,  &writer, E_INVALIDARG},
+        {NULL,     &stream, &attr, &writer, S_OK},
+        {tmp_file, NULL,    NULL,  &writer, S_OK},
+        {tmp_file, NULL,    &attr, &writer, S_OK},
+        {tmp_file, &stream, NULL,  &writer, S_OK},
+        {tmp_file, &stream, &attr, &writer, S_OK},
+    };

-    writer = (void *)0xdeadbeef;
-    hr = MFCreateSinkWriterFromURL(NULL, NULL, NULL, &writer);
-    ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr);
-    ok(!writer, "Unexpected pointer %p.\n", writer);
+    /* Get temp file name. */
+    GetTempPathW(ARRAY_SIZE(tmp_file), tmp_file);
+    wcscat(tmp_file, L"tmp.mp4");
+
+    /* Create attribute and byte stream. */
+    hr = MFCreateAttributes(&attr, 1);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = IMFAttributes_SetGUID(attr, &MF_TRANSCODE_CONTAINERTYPE, &MFTranscodeContainerType_MPEG4);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);
+    hr = MFCreateTempFile(MF_ACCESSMODE_READWRITE, MF_OPENMODE_DELETE_IF_EXIST, MF_FILEFLAGS_NONE, &stream);
+    ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);

+    /* Test MFCreateSinkWriterFromURL. */
+    for (i = 0; i < ARRAY_SIZE(create_sink_writer_from_url_tests); ++i)
+    {
+        struct create_sink_writer_from_url_test *test = &create_sink_writer_from_url_tests[i];
+        IMFByteStream *test_stream = test->stream ? *test->stream : NULL;
+        IMFAttributes *test_attr = test->attr ? *test->attr : NULL;
+
+        winetest_push_context("Test %u", i);
+
+        writer = (void *)0xdeadbeef;
+        hr = MFCreateSinkWriterFromURL(test->url, test_stream, test_attr, test->writer);
+        todo_wine_if(test->hr == S_OK)
+        ok(hr == test->hr, "Unexpected hr %#lx, expected %#lx.\n", hr, test->hr);
+        if (test->writer)
+            todo_wine_if(test->hr == S_OK)
+            ok((test->hr == S_OK && writer) || (test->hr != S_OK && !writer), "Unexpected writer pointer %p.\n", writer);
+
+        if (hr == S_OK)
+            IMFSinkWriter_Release(writer);
+
+        winetest_pop_context();
+    }
+
+    /* Test MFCreateSinkWriterFromMediaSink. */
     hr = MFCreateSinkWriterFromMediaSink(NULL, NULL, NULL);
     ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr);

@@ -1435,6 +1487,8 @@ static void test_sink_writer(void)
     hr = MFCreateSinkWriterFromMediaSink(NULL, NULL, &writer);
     ok(hr == E_INVALIDARG, "Unexpected hr %#lx.\n", hr);
     ok(!writer, "Unexpected pointer %p.\n", writer);
+
+    winetest_pop_context();
 }

START_TEST(mfplat)
@@ -1451,7 +1505,7 @@ START_TEST(mfplat)
     test_source_reader("test.mp4", true);
     test_source_reader_from_media_source();
     test_reader_d3d9();
-    test_sink_writer();
+    test_sink_writer_create();

hr = MFShutdown();
     ok(hr == S_OK, "Unexpected hr %#lx.\n", hr);