On Mon Oct 7 11:33:05 2024 +0000, Connor McAdams wrote:
Would you prefer if I change the things you've pointed out now, or can those wait for the next MR? Don't want to add another round of review work for you if I don't have to, but I am willing to change those things if you want me to :) I've already fixed these locally, just let me know if I should push them. I guess they're mostly style changes aside from the assert, so it shouldn't need too much review. :)
Either way is fine; I approved the MR already but I can certainly give it another look with the changes (agreed it should be quick :sweat_smile:)