On Tue Oct 31 13:42:24 2023 +0000, Jacek Caban wrote:
Removing weak references is questionable in some of those cases. We're not in an environment fully controlled by cycle collector, those objects are exposed as regular COM objects. Even making cycle collector aware of JS objects will not change that. I think it's fine for some simple cases like constructors, for which it's unlikely to matter. But things like parent window reference would need a strong argument to change, IMHO.
I see. I wanted to keep it consistent with the rest, and also to get rid of semi hacks like in `set_frame_doc`. That said I'm also a bit worried it feels somewhat arbitrary, although it doesn't matter if it's an implementation detail only, so I'll see if I can find a way to test these and see what happens… otherwise I'll get rid of it.
Note that some things are actually tested to work by being detached, like the navigator's `mimeTypes` or `plugins`, so who knows.