28 May
2024
28 May
'24
9:16 p.m.
On Sat May 18 08:22:49 2024 +0000, Piotr Caban wrote:
Did you consider changing `get_args` prototype to something like: `static char* get_args(struct parsed_symbol* sym, BOOL func)`? I think that `z_term` argument name is not very descriptive. `open_char` and `close_char` seems to be redundant.
yes I thought about it (with same reasoning as yours). Didn't do it at once because I wondered where to put the open/closing argument (keep it inside get_args() as it is today or move it to caller site) and I wanted to cover the throw clauses that we don't handle yet first (to check the impacts -if any- in handling of end of parameters' type list marker). will include in next round if it fits well.