Re: [PATCH v4 0/2] MR907: secur32: Implement basic functionality for LsaGetLogonSessionData.

[Hans Leidekker (＠hans)]

Hans Leidekker (@hans) commented about dlls/secur32/lsa.c:
>      PSECURITY_LOGON_SESSION_DATA* ppLogonSessionData)
>
> {
> - FIXME("%p %p stub\n", LogonId, ppLogonSessionData);
> - *ppLogonSessionData = NULL;
> - return STATUS_NOT_IMPLEMENTED;
> - SECURITY_LOGON_SESSION_DATA *data;
> - int authpkg_len;
> - WCHAR *end;
> -
> - FIXME("%p %p semi-stub\n", LogonId, ppLogonSessionData);
> -
> - authpkg_len = wcslen(default_authentication_package) * sizeof(WCHAR);
> -
> - data = calloc(1, sizeof(SECURITY_LOGON_SESSION_DATA) + authpkg_len + sizeof(WCHAR));
> -
> - data->Size = sizeof(SECURITY_LOGON_SESSION_DATA);

Checking for allocation failure would be nice. I prefer sizeof(*data) over sizeof(SECURITY_LOGON_SESSION_DATA) but it's not a big deal. Otherwise it looks good.