Re: [PATCH v2 0/6] MR543: wined3d: Cache the output mode lists where possible.

[Jan Sikorski (＠jsikorski)]

Jan Sikorski (@jsikorski) commented about dlls/wined3d/directx.c:
> - output->modes_valid = true;
>
> +}
> -
>
> +static bool mode_matches_filter(const struct wined3d_adapter *adapter, const struct wined3d_display_mode *mode,
> -
>    const struct wined3d_format *format, enum wined3d_scanline_ordering scanline_ordering)
>
> +{
> - if (scanline_ordering != WINED3D_SCANLINE_ORDERING_UNKNOWN
> -
>        && mode->scanline_ordering != WINED3D_SCANLINE_ORDERING_UNKNOWN
> -
>        && scanline_ordering != mode->scanline_ordering)
> -
>    return false;
> -
> - if (format->id == WINED3DFMT_UNKNOWN)
> - {
> -
>    /* This is for d3d8, do not enumerate P8 here. */
> -
>    if (mode->format_id != WINED3DFMT_B5G6R5_UNORM && mode->format_id != WINED3DFMT_B8G8R8X8_UNORM)
> -
>        return false;

Is this right, do we want only these 2 formats to pass the filter? It looks backwards, but if I'm wrong, it could use more explanation.