On Thu Jul 28 19:20:42 2022 +0000, Jeffrey Smith wrote:
I must say I am a bit confused by the way gitlab shows the diff and
why the testbot reports failures. Afaics the failures are in a different test though. I struggled with figuring this out too, but eventually realized that with b12afe42, the changed background color (0.5,0.5,0.5/0x7f7f7f) was being picked up by a subsequent Clear. 46434c88 restores the background color after the Render test, so everything looks good now.
@alesliehughes I think the only issue remaining with this was changing the commit topic, as suggested by @stefan. All other concerns appear to have been addressed, but the threads were never marked as resolved. If you could push the commit topic change, maybe this could be out of the open MR list soon.