On Sat Jul 16 07:48:14 2022 +0000, eric pouech wrote:
fixed in v2 (thx for the review) BTW, concerning the ERR vs FIXME thingie. I agree that FIXME is better in this case (from Internet sources, all letters from A to Z are used) But I wonder what to do with the rest of file undname.c which heavily uses ERR... in lots of case we're in a gray area: not precisely knowing if the given input is really a valid input (and FIXME is to be used) or if it's an invalid input (and ERR should be used)
The function behavior is changing so it kind of makes sense to use FIXME instead of ERR in many places (I guess that e.g. operator "" support will be added to msvcrt in future updates). In theory we can try to guess what parts are likely to change (and use FIXME there) and parts that should use ERR but that doesn't look doable. I would vote for leaving it as is unless the code is changed for other reasons (and than it can be decided on case by case basis).