Re: [PATCH v3 0/1] MR8937: windows.media.playback.backgroundmediaplayer: Implement IBackgroundMediaPlayerStatics::get_Current().

[Mohamad Al-Jaf (＠maljaf)]

On Thu Sep 11 03:53:33 2025 +0000, Rémi Bernon wrote:
> This works because you also guard the factory QueryInterface, but I
> would say it's not the canonical way to do it. Guarding the factory
> AddRef shouldn't be necessary, and instead you should probably check the
> ref count again within the critical section:
>         EnterCriticalSection( &media_player_cs );
>         if (!impl->ref && impl->media_player)
>         {
>             IMediaPlayer_Release( impl->media_player );
>             impl->media_player = NULL;
>         }
>         LeaveCriticalSection( &media_player_cs );

I see, thanks.