Re: [PATCH v3 0/4] MR4441: Adding tests for CreateProcess and std handles.

[eric pouech (＠epo)]

On Thu Nov 30 17:24:54 2023 +0000, Jacek Caban wrote:
> This causes warnings on 64-bit clang about unused functions:
> dlls/kernel32/tests/process.c:639:20: warning: unused function
> 'ok_child_hexint' [-Wunused-function]
>   639 | static inline void ok_child_hexint( int line, const char *sect,
> const char *key, UINT expect, UINT is_broken )
>       |                    ^~~~~~~~~~~~~~~
> dlls/kernel32/tests/process.c:3109:20: warning: unused function
> 'copy_change_subsystem' [-Wunused-function]
>  3109 | static inline void copy_change_subsystem(const char* in, const
> char* out, DWORD subsyst)
>       |                    ^~~~~~~~~~~~~~~~~~~~~
> dlls/kernel32/tests/process.c:3146:20: warning: unused function
> 'check_run_child' [-Wunused-function]
>  3146 | static inline BOOL check_run_child(const char *exec, DWORD
> flags, BOOL cp_inherit,
>       |                    ^~~~~~~~~~~~~~~
> dlls/kernel32/tests/process.c:3172:20: warning: unused function
> 'build_startupinfo' [-Wunused-function]
>  3172 | static inline BOOL build_startupinfo( STARTUPINFOA *startup,
> unsigned args, HANDLE hstd[2] )
>       |                    ^~~~~~~~~~~~~~~~~
>
> I'm not sure why those tests are disabled on 64-bit, a quick test
> suggests that it should work.

existing (before this MR) 64bit code doesn't compile well (lots of warning for pointer to integer conversion in 64bit)

that maybe the cause ; don't know for sure

so I wrapped in first commit these function inside a #ifndef block and enabled 64bit compilation after first commit (in separate patch) so that we don't have to first the warnings above and remove all of it afterwards