Re: [PATCH v5 0/7] MR662: vkd3d-shader/ir: Introduce a better CFG structurizer, part 2.

[Conor McCarthy (＠cmccarthy)]

Conor McCarthy (@cmccarthy) commented about libs/vkd3d-shader/ir.c:
>  return bitmap_is_set(b1->dominates, b2->label - 1);
>
> }
>
> +/* This helper is very similar to the previous one, and it exists
> -
> - mostly to express intent. It assumes that an edge from `from' to
> -
> - `to' exists. */
>
> +static bool vsir_block_is_back_edge(struct vsir_block *from, struct vsir_block *to)

On balance I see no improvement in clarity from this function. The assumption that an edge exists makes the function name inaccurate, and it is equal to `vsir_block_dominates()` except that it reverses the parameters. It may be better just to add a comment where `vsir_block_dominates()` is called to prove a back edge.