Re: [PATCH v3 0/5] MR765: tests: Do not crash on llvmpipe.

[Henri Verbeet (＠hverbeet)]

> +    /* llvmpipe has maxBoundDescriptorSet == 8, which is smaller than we currently need. */

"... which is less than ...", probably. Might not hurt to include version information here as well.
> +        /* llvmpipe crashes with mutable descriptors are used. I don't
> +         * know yet whether this is a bug in vkd3d or Mesa. */

"crashes when"
> +static void get_physical_device_properties(
> +        ID3D12Device *device, VkPhysicalDeviceProperties *device_properties)
> +{
> +    PFN_vkGetPhysicalDeviceProperties pfn_vkGetPhysicalDeviceProperties;
> +    VkPhysicalDevice vk_physical_device;
> +    VkInstance vk_instance;
> +
> +    vk_instance = vkd3d_instance_get_vk_instance(vkd3d_instance_from_device(device));
> +    pfn_vkGetPhysicalDeviceProperties = (void *)vkGetInstanceProcAddr(vk_instance,
> +            "vkGetPhysicalDeviceProperties");
> +    vk_physical_device = vkd3d_get_vk_physical_device(device);
> +    pfn_vkGetPhysicalDeviceProperties(vk_physical_device, device_properties);
> +}

I think the main point of this function is retrieving "device_properties.driverVersion" in is_llvmpipe_device_gte(), right? Should we just return "device_properties2.properties.driverVersion" from get_driver_properties() instead?