On Fri Apr 12 19:18:49 2024 +0000, Gabriel Ivăncescu wrote:
Nope, the only thing I extend to IE8 and below are the cycle collection integration, since it helps as well (with only like a single extra line of code). What I meant is that, in theory, InvokeEx (on mshtml side!) does receive a "this" argument, in IE8 and below, simplest case is when called from C code. Even though no mshtml object seems to make use of it. So I wanted to keep it generic and play it safe and thus "pass the same thing" if a jscript proxy receives that "this" arg, but if it's not required I'll just get rid of it. :) BTW for this MR, I already got rid of "on_put" now in a patch, since we override the prop_put on Arrays. That's an example of how the jscript proxy would work as well, except it would be at the top of the function before it's forwarded.
It's better now, but I still can't review it on its own while MSHTML bindings design is so blurry. I think it will be better to have a bit more complete prototype for the context before upstreaming its pieces.