Re: [PATCH 0/6] MR61: vkd3d-shader/hlsl: Add field-level documentation to the most important structs in hlsl.h. (PART 2/2)

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about libs/vkd3d-shader/hlsl.h:
>  size_t name_bytecode_offset;
>
> };
>
> +/* Information of the register allocated for an instruction node or variable.
> -
> - These values are initialized at the end of hlsl_emit_bytecode(), after the compilation passes,
> -
> - just before writing the bytecode.
> -
> - For numeric registers, a writemask can be provided to indicate the reserve of only some of the
> -
> - 4 components.
> -
> - The type of register (register class) is implied from its use, so it is not stored in this
> -
> - struct. */
>
> struct hlsl_reg
>  {
>      uint32_t id;
>      unsigned int writemask;
> - /* If the register has been allocated already. */

Yeah, though "already" only covers the connotation relevant to RA itself. The other connotation is "is this register even used?" which matters for uniforms. I dunno how I'd reword this at all, except maybe to just delete the "already" (also, 'whether' rather than 'if' probably, but that's just a language nitpick).