On Thu Mar 14 18:35:03 2024 +0000, Zebediah Figura wrote:
I don't think this seems necessary. I'd just put them in device.c.
Having them in a separate test makes it possible to run the testbot on d3d9on12 functions only, which might be helpful when dealing with test failures as it makes it clear what and where the test is failing, especially since a lot of test messages in Wine are generic, like "Got hr", which would require navigating the test file to the specific line(s) it failed at. Plus, the bigger tests take longer to execute, and when dealing with debugging flaky tests, this can add up rather quickly.
It's also nice to organize all the required modules and functions in one file especially since they're only used for this specific function, but that's just my opinion; I find big files hard to navigate.
I'll wait for a consensus on this matter before pushing an update. I'm open to putting it anywhere.