Re: [PATCH 0/2] MR8589: cmd/tests: Don't use if errorlevel 0

[Alfred Agrell (＠Alcaro)]

On Fri Jul 18 09:42:57 2025 +0000, eric pouech wrote:
> the fixes for DEL are ok (still need to decide upon overlap and comments
> from MR8588)
> (side note: internally `errorlevel` is a signed integer, and can be set
> to a negative value. so, generally speaking, `if errorlevel 0` is still
> a valid and meaningful statement and is not always true; AFAICT DEL's
> doesn't set errorlevel to a negative value)

Technically true, but accepting both zero and (some) nonzero errorlevels is quite implausible. If such behavior is desired, it should be rewritten to if %errorlevel% geq 0, or prominently commented.

In this case, they're clearly intended to be equality comparisons.