Re: [PATCH 0/3] MR749: vkd3d-shader/ir: Minimise temp usage.

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/ir.c:
> -
>    ssa->table[ssa_id] = UINT_MAX;
> -
>    ++count;
> - }
> -
> - for (i = 0; i < reg->idx_count; ++i)
> -
>    if (reg->idx[i].rel_addr)
> -
>        count += register_map_undominated_use(&reg->idx[i].rel_addr->reg, ssa, block, origin_blocks);
> -
> - return count;
>
> +}
> -
>
> +/* Drivers are not necessarily optimised to handle very large numbers of temps. For example,
> -
> - using them only where necessary fixes stuttering issues in Horizon Zero Dawn on RADV.
> -
> - This can also result in the backend emitting less code because temps typically need an
> -
> - access chain and a load/store. */
>
> +static enum vkd3d_result vsir_program_materialize_undominated_ssas_to_temps(struct vsir_cfg *cfg)

I guess this should have a `vsir_cfg_` prefix, to fit with the convention we're (slowly) moving to.