Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/hlsl_codegen.c:
}}
-static const struct hlsl_ir_var *get_reserved_object(struct hlsl_ctx *ctx, char type, uint32_t index) +static const struct hlsl_ir_var *get_reserved_object(struct hlsl_ctx *ctx, enum hlsl_regset regset,
uint32_t index){ const struct hlsl_ir_var *var;
LIST_FOR_EACH_ENTRY(var, &ctx->extern_vars, const struct hlsl_ir_var, extern_entry) {
if (var->last_read && var->reg_reservation.type == type && var->reg_reservation.index == index)
if (var->reg_reservation.type == hlsl_regset_name(regset) && var->reg_reservation.index == index)
I don't know how the others feel about that, but in general my philosophy is that you shouldn't mix refactoring and changing the behavior in a single commit. If you want to change (either fix a bug or implement something new), you do in a commit just dedicated to that; if you want to refactor, you ensure that the external behavior of the program is not changed by that commit. This should help bisections to give useful results.