Re: [PATCH v2 0/2] MR6492: d2d1: Implement drawing of ID2D1GeometryGroup

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/d2d1/geometry.c:
> HRESULT d2d_geometry_group_init(struct d2d_geometry *geometry, ID2D1Factory *factory,
>          D2D1_FILL_MODE fill_mode, ID2D1Geometry **geometries, unsigned int geometry_count)
>  {
> - unsigned int i;
> -
>
> unsigned int i, j;
> -
>
> struct d2d_geometry *other_geom;
> -
>
> D2D_MATRIX_3X2_F g, gplain;
> -
>
> size_t f_vertex_count, f_face_count, f_bezier_vertex_count, f_arc_vertex_count;
> -
>
> size_t o_vertex_count, o_face_count, o_bezier_count, o_bezier_face_count, o_arc_count, o_arc_face_count;
> -
>
> FIXME("Ignoring fill_mode=%#x!\n", fill_mode);

It looks to me that there won't be any way to retroactively apply fill mode later, once you have copied all the vertices. But I'm not sure what's the correct way would be here.