On Thu Apr 25 19:50:23 2024 +0000, Elizabeth Figura wrote:
I think a lot of good MRs are being submitted and left into dust, a
system that allow MRs to be aproved by other developers would allow more MRs to be accepted, like for example, a lot of simple stubs are not being merged and someone passing though MRs found out that https://gitlab.winehq.org/wine/wine/-/merge_requests/5522 code was a containing a duplicate of https://gitlab.winehq.org/wine/wine/-/merge_requests/2374 cause the stub was required to run an installer. I don't understand? Merge requests can already be approved by anyone, regardless of whether they're an assigned reviewer or maintainer or not. As explained in 5522, 2374 was never accepted because it didn't actually help anything.
@zfigura I would appreciate it if the "didn't actually help anything" concerns regarding my patches were made in the MR containing them. That would be so that I could have the opportunity to make improvements to them in response to your feedback.