Re: [PATCH v9 0/5] MR2091: windows.media.speech: Initial Unixlib work.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/windows.media.speech/unixlib.h:
> +{
> - vosk_handle vosk_handle;
> - CHAR locale[LOCALE_NAME_MAX_LENGTH];
> - FLOAT sample_rate;
>
> +};
> -
>
> +struct vosk_release_params
> +{
> - vosk_handle vosk_handle;
>
> +};
> -
>
> +enum unix_funcs
> +{
> - unix_vosk_create,
> - unix_vosk_release,
>
> +};

A suggestion which should address the `vosk` namespace comment made in some of the discussion thread, would be to use `speech` here instead or some other generic prefix.

Although the unixlib interface might be designed a little bit to match the backend library usage, I don't think we need to tightly couple it with a specific backend, and having a generic prefix and generic unixlib interface will make it easier to change to (or add) a different backend in the future.