Hi
thanks for the submission
from a cursory look (didn't go into the implementation details): - don't use C++ comment - don't do white space only changes - don't put several semi-colons at the end of line - the second commit should be merged into the first one - you could do without 'goto':s in implementation - there's lots of FIXME:s inside the code, letting think that the work isn't fully done - please start with a commit adding tests for RtlDosPathNameToRelativeNtPathName_U_WithStatus; that could (maybe) help with previous bullet point => this should cover: access rights (why did you remove the DELETE access flag in second commit?, what's the handling of relative parameter (optional?, zero out content in case of error?...) - second commit should be your implementation changes