Re: [PATCH v8 0/2] MR7623: winegstreamer: Use provided PTS and duration in video_decoder.

[Rémi Bernon (＠rbernon)]

Rémi Bernon (@rbernon) commented about dlls/winegstreamer/wg_transform.c:
> - {
> -
>    dts = sample->dts += transform->ts_offset;
> -
>    if (dts < 0)
> -
>    {
> -
>        if (transform->ts_offset == 0)
> -
>            transform->ts_offset = -dts;
> -
>        else
> -
>            GST_WARNING("dts %ld is less than zero after applying ts_offset %ld\n", (long int)dts, (long int)transform->ts_offset);
> -
>        dts = 0;
> -
>    }
> -
>    GST_BUFFER_DTS(buffer) = dts * 100;
> - }
> if (sample->flags & WG_SAMPLE_FLAG_HAS_PTS)
> -
>    GST_BUFFER_PTS(buffer) = sample->pts * 100;
> - {
> -
>    pts = sample->pts += transform->ts_offset;

The sample variable isn't const but I don't think it's meant to be modified in this function. Is there any reason it needs to be?