Hans Leidekker (@hans) commented about dlls/wininet/tests/internet.c:
test_data[] = { { "Fri, 07 Jan 2005 12:06:35 GMT", &expect1, TRUE },
{ "Fri, 07 Jan 2005 12:06:35 UTC", &expect1, TRUE }, { " fri, 7 jan 2005 12 06 35", &expect1, TRUE }, { "Fri, 07-01-2005 12:06:35", &expect1, TRUE }, { "5, 07-01-2005 12:06:35 GMT", &expect1, TRUE },{ "5, 07-01-2005 12:06:35 UTC", &expect1, TRUE },
It would be nice to test HTTP_ParseDateAsAsctime() as well. Something like this on top of your patch:
``` diff --git a/dlls/wininet/tests/internet.c b/dlls/wininet/tests/internet.c index 176cfcc8961..eeb50bdb9fc 100644 --- a/dlls/wininet/tests/internet.c +++ b/dlls/wininet/tests/internet.c @@ -928,6 +928,9 @@ static void test_InternetTimeToSystemTime(void) { "2, 11*01/2022 11+13=05", &expect2, TRUE }, { "2, 11-Jan-2022 11:13:05", &expect2, TRUE }, { "Fr", NULL, FALSE }, + { "Fri Jan 7 12:06:35 2005", &expect1, TRUE }, + { "Fri Jan 7 12:06:35 2005 GMT", &expect1, TRUE }, + { "Fri Jan 7 12:06:35 2005 UTC", &expect1, TRUE }, };
ret = pInternetTimeToSystemTimeA(NULL, NULL, 0); ```