26 May
2025
26 May
'25
7:25 a.m.
On Mon May 26 07:25:12 2025 +0000, eric pouech wrote:
a couple of comments:
- please read and conform to [Wine Coding style](https://gitlab.winehq.org/wine/wine/-/wikis/Wine-Developer%27s-Guide/Coding-...)
- AFAICT ReadConsoleInputEx[AW] isn't defined in Windows SDK so header
files shouldn't be changed
- tests must reflect what Windows does, not what your implementation
does (hence the generated failures in CI pipeline)
- this should be implemented using proper (new or modified) IOCTL:s;
there's no way this API can be implemented on top of kernel32's one without being racy (as your proposal is). That's the reason why MS introduced this new API.
Hi @epo I did a few changes but, I still cannot figure out why the tests on Windows return invalid handle but when I locally build the tests and copy kernel32_tests.exe to a Windows 11 and Windows 10 machine and run kernel32_tests.exe both work, any idea if there is something different I should do?