Re: [PATCH v3 0/2] MR6059: mf: Retry PROCESSINPUTNOTIFY if TRANSFORM_TYPE_NOT_SET is returned.

[Nikolay Sivov (＠nsivov)]

Nikolay Sivov (@nsivov) commented about dlls/mf/evr.c:
>      }
>
>      if (SUCCEEDED(IMFTransform_ProcessInput(stream->parent->mixer, stream->id, sample, 0)))
> -
>        IMFVideoPresenter_ProcessMessage(stream->parent->presenter, MFVP_MESSAGE_PROCESSINPUTNOTIFY, 0);
> -
>    {
> -
>        if (IMFVideoPresenter_ProcessMessage(stream->parent->presenter, MFVP_MESSAGE_PROCESSINPUTNOTIFY, 0) == MF_E_TRANSFORM_TYPE_NOT_SET)
> -
>        {
> -
>            IMFVideoPresenter_ProcessMessage(stream->parent->presenter, MFVP_MESSAGE_INVALIDATEMEDIATYPE, 0);
> -
>            IMFVideoPresenter_ProcessMessage(stream->parent->presenter, MFVP_MESSAGE_PROCESSINPUTNOTIFY, 0);
> -
>        }
> -
>    }

It's not clear what it should do if MFVP_MESSAGE_PROCESSINPUTNOTIFY keeps failing, of if MFVP_MESSAGE_INVALIDATEMEDIATYPE fails. Regarding the tests, the main problem is that such tests quickly become unmanageable, once you add some other paths to test different situation. Also it's covered with broken() checks all over. It might be better to figure out first if we need to retry more than once, and then strip the tests and attach them as a plain diff for this MR.