On Tue Jun 20 09:01:44 2023 +0000, Huw Davies wrote:
I believe this is unnecessary as the driver should only return `S_FALSE` in the `AUDCLNT_SHAREMODE_SHARED` case where `out` will be non-NULL. However, it would be a good idea to move the parameter checks that are currently done in the first few lines of each driver into `mmdevapi` - @davidebeatrici something to add to the list (not really a priority though).
I added a test that crashes (when using pulse) due to this null dereference. In certain situations there is still a null reference, although I'm not 100% sure if that's the right place to check it. It's not supposed to return S_FALSE when it's NULL, see the tests. But I currently don't have a better idea, at least this gets rid of the crash.