On Mon Aug 28 13:36:05 2023 +0000, **** wrote:
Marvin replied on the mailing list:
Hi, It looks like your patch introduced the new failures shown below. Please investigate and fix them before resubmitting your patch. If they are not new, fixing them anyway would help a lot. Otherwise please ask for the known failures list to be updated. The tests also ran into some preexisting test failures. If you know how to fix them that would be helpful. See the TestBot job for the details: The full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=136746 Your paranoid android. === w10pro64 (64 bit report) === d3d9: device.c:4159: Test failed: Expected message 0x46 for window 0x1, but didn't receive it, i=0. device.c:4203: Test failed: Expected message 0x7e for window 0, but didn't receive it, i=0. device.c:4207: Test failed: The device window is active, i=0. device.c:4212: Test failed: Got unexpected hr 0x88760869. device.c:4216: Test failed: Got unexpected screen size 800x600. device.c:4241: Test failed: Expected the device window to still be iconic. device.c:4260: Test failed: Expected message 0x46 for window 0, but didn't receive it, i=0. device.c:4269: Test failed: Got unexpected screen size 800x600. device.c:4286: Test failed: Expected message 0x7e for window 0, but didn't receive it, i=0. device.c:4294: Test failed: Got unexpected width 640. device.c:4295: Test failed: Got unexpected height 480. device.c:4376: Test failed: Expected message 0x7e for window 0x1, but didn't receive it, i=0. device.c:4383: Test failed: Expected IsIconic 1, got 0, i=0. device.c:4387: Test failed: Got unexpected hr 0. device.c:4395: Test failed: Expected message 0x46 for window 0x1, but didn't receive it, i=0. device.c:4433: Test failed: Expected message 0x1c for window 0x1, but didn't receive it, i=0. device.c:4443: Test failed: Got unexpected hr 0. device.c:4501: Test failed: Expected message 0x18 for window 0, but didn't receive it, i=0. device.c:4507: Test failed: Got unexpected WINDOWPOS hwnd=0000000000000000, insertAfter=0000000000000000, x=0, y=0, cx=0, cy=0, flags=0 device.c:4524: Test failed: Expected the device window to be visible, i=0.
The full output of this has the following line:
`device.c:4142: Tests skipped: Not running in foreground, skip foreground window test`
Which doesn't show up on the same machine on 32 bit, where the tests pass.
The change to test_reset_fullscreen() runs before the failing test_wndproc here, so it has the potential to somehow convince windows that a different program has the user's attention. The failure did not show up on a manual re-run (https://testbot.winehq.org/JobDetails.pl?Key=136757#k318). Otoh this test seems to have been very stable in the past on Windows, so it isn't something I want to wave away easily. (http://test.winehq.org/data/tests/d3d9:device.html)
Also cause for concern, the Linux testbot is still failing test_wndproc despite manually re-minifying the window: https://testbot.winehq.org/JobDetails.pl?Key=136757#k401