Re: [PATCH 0/10] MR2520: imm32: More tests and being selecting the IME from ImmLockIMC.

[Byeongsik Jeon (＠bsjeon)]

Byeongsik Jeon (@bsjeon) commented about dlls/imm32/imm.c:
>  else if (!(imc->ime = ime_acquire( hkl )))
>      WARN( "Failed to acquire IME for HKL %p\n", hkl );
>  else
> - {
> -
>    if (!(imc->IMC.hPrivate = ImmCreateIMCC( imc->ime->info.dwPrivateDataSize )))
> -
>        WARN( "Failed to allocate IME private data for IMC %p\n", imc );
> -
>    imc->IMC.fdwConversion = imc->ime->info.fdwConversionCaps;
> -
>    imc->IMC.fdwSentence = imc->ime->info.fdwSentenceCaps;

This is an issue with the old code, not with this MR, but I'm commenting in hopes that it will be added to the TODO list. Maybe it's already up there.

Setting capability values to default value is not appropriate. This seems to be the domain of IME, not IMM.
In fact, there is a native-IME that is misbehaving because of these two lines.

Thanks.