Re: [PATCH v2 0/6] MR716: windows.devices.enumeration: Add DeviceWatcher class and IDeviceInformationStatics2 interface.

[Rémi Bernon (＠rbernon)]

R��mi Bernon (@rbernon) commented about dlls/windows.devices.enumeration/main.c:
>      IDeviceInformationStatics2 *iface, HSTRING filter, IIterable_HSTRING *additionalProperties,
>      DeviceInformationKind kind, IDeviceWatcher **watcher)
>
> {
> - struct device_watcher *this;
> - HRESULT hr;
> - FIXME("iface %p, filter %s, additionalProperties %p, kind %u, watcher %p stub!\n",
>            iface, debugstr_hstring(filter), additionalProperties, kind, watcher);
> - return E_NOTIMPL;
> -
> - if (!(this = malloc(sizeof(*this))))

Please use calloc for object allocation, like everywhere else. It avoids issues with uninitialized members and saves you the initialization to 0 / NULL. As you're implementing the function you should probably change the FIXME into a TRACE and remove the "stub!".