Re: [PATCH 0/10] MR2275: winewayland.drv: part 1: Introduce the Wayland driver

[Jacek Caban (＠jacek)]

Jacek Caban (@jacek) commented about dlls/winewayland.drv/waylanddrv.h:
> BOOL wayland_process_init(void) DECLSPEC_HIDDEN;
>
> +/**********************************************************************
> -
> -
>      Wayland mutex
> - */
> -
>
> +void wayland_mutex_init(struct wayland_mutex *wayland_mutex, int kind,
> -
>                    const char *name) DECLSPEC_HIDDEN;
>
> +void wayland_mutex_destroy(struct wayland_mutex *wayland_mutex) DECLSPEC_HIDDEN;
> +void wayland_mutex_lock(struct wayland_mutex *wayland_mutex) DECLSPEC_HIDDEN;
> +void wayland_mutex_unlock(struct wayland_mutex *wayland_mutex) DECLSPEC_HIDDEN;

While patch splitting is generally very much appreciated, introducing (temporary) dead code in the process is discouraged in Wine. An alternative way to split is to introduce those helpers together with a code that uses it, but keep it as a very simple pthread wrappers. Then, in a next commit, you could implement additional robustness checks.