On Sun Jul 16 10:23:07 2023 +0000, Sven Baars wrote:
Maybe to isolate the issue a bit more, you could move `get_audio_session_wrapper` into `mmdevapi` first, then call it from all the `AUDDRV_GetAudioSessionWrapper` methods in separate commits (probably while also removing the vtbl definitions etc.), and then in the final commit, remove `GetAudioSessionWrapper` from the `DriverFuncs`. Right now you already do this in the first commit.
Stared at this for a bit yesterday, narrowed it down to `ASM_GetSimpleAudioVolume`, calling `get_audio_session_wrapper` through `AUDDRV_GetAudioSessionWrapper` "fixes" the tests.
For some reason, the sessions list changes address halfway through the test, and it ends up creating a new session instead. ``` 00d0:fixme:mmdevapi:get_audio_session ({faaab7e1-480b-4230-b5e6-8e09a3cc3adb}, 000000000038F110, 0, 000000000021FAC8) sessions 00000002EB239100 00d0:fixme:mmdevapi:get_audio_session ({faaab7e1-480b-4230-b5e6-8e09a3cc3adb}, 000000000038DD70, 0, 000000000021FAC8) sessions 00000002EB239100 00d0:fixme:mmdevapi:get_audio_session ({faaab7e1-480b-4230-b5e6-8e09a3cc3adb}, 000000000038DD70, 2, 0000000000383B70) sessions 00000002EB239100 00d0:fixme:mmdevapi:get_audio_session ({faaab7e1-480b-4230-b5e6-8e09a3cc3adb}, 000000000038F110, 2, 0000000000383C40) sessions 00000002EB239100 00cc:render: 21 tests executed (0 marked as todo, 0 as flaky, 0 failures), 0 skipped. ``` ``` 00d0:fixme:mmdevapi:get_audio_session ({ccd800bb-46ca-418f-8020-0988753a38c4}, 000000000038F110, 0, 000000000021FAC8) sessions 000000020F413260 00d0:fixme:mmdevapi:get_audio_session ({ccd800bb-46ca-418f-8020-0988753a38c4}, 000000000038DD70, 0, 000000000021FAC8) sessions 000000020F413260 00d0:fixme:mmdevapi:get_audio_session ({ccd800bb-46ca-418f-8020-0988753a38c4}, 000000000038DD70, 2, 0000000000383B70) sessions 00000002EB239100 00d0:fixme:mmdevapi:get_audio_session ({ccd800bb-46ca-418f-8020-0988753a38c4}, 000000000038F110, 2, 0000000000383C40) sessions 00000002EB239100 00cc:render: 21 tests executed (0 marked as todo, 0 as flaky, 1 failure), 0 skipped. ```