What is this nonsense about serial ports?
My attempt to explain why I have 4 tests unrelated to my changes that fail suddently.
Okay, that's not clear at all.
Why are you using AI?
To help me diagnose and fix complex behaviors like this. Are you biased?
Yes, probably. AI generated text is difficult to read and often full of statements that are blatantly or subtly wrong. This is no exception.
But mainly I ask why you're using it when things would be an awful lot easier if you didn't. You don't need 600 words to explain things that are obvious from reading the patch. You don't need another 700 words to say what should just be "the kernel32:comm tests are failing in a way unrelated to this patch". Asking anyone to read all that garbage is wasting their time.
And I suspect that using AI to generate the patch contents, if you did, is not going to be better than writing yourself. Certainly not better than consulting existing Wine developers for help, which would have prevented a lot of mistakes I can see, not just now but in the future, and is generally better for collaboration.
More pressingly, according to my understanding, AI are trained on code with a license incompatible to Wine, and I don't believe any output can be used safely in our project.
What application needs this?
NUMA topology? I could think of a few examples :smile:
What are they? We don't accept new features as a rule unless something needs them.
@nsivov You can move it around, where you want afterwards.
That's not how we do things around here I'm afraid; we don't commit patches with known insufficiencies as a general rule.