Re: [PATCH v8 0/6] MR1857: Draft: comdlg32: IFileDialog navigation bar

[Esme Povirk (＠madewokherd)]

Esme Povirk (@madewokherd) commented about dlls/comdlg32/navbar.c:
> -
>        if (crumb2_size > min_crumb_w)
> -
>            crumb2_size = min_crumb_w;
> -
> -
>        /* calculate how much extra space is required to fit both crumbs */
> -
>        w = (crumb1->full_w + crumb2_size) - max_crumbs_w;
> -
>        if (w > 0)
> -
>        {
> -
>            /* not enough space for last crumb, truncate it */
> -
>            crumb1->current_w = max(0, crumb1->full_w - w);
> -
>            crumb2->current_w = crumb2_size;
> -
>        }
> -
>        else
> -
>        {
> -
>            /* enough space for last crumb, let the second crumb take leftover space */
> -
>            crumb2_size = max_crumbs_w - crumb1->full_w;
> -
>            if (crumb2_size < crumb2->full_w)

When can this condition be false? If the statement is false then that would seem to imply that both crumbs fully fit, and the code shouldn't be reached.