On Tue Jun 6 16:42:42 2023 +0000, Henri Verbeet wrote:
I don't have a very strong opinion. Multiple discard types are fine;
v1 of this patch was also fine. I mostly just want the IR to have the same semantics regardless of profile version. I don't disagree, but it's perhaps worth pointing out that technically that would imply having two variants of things like "mul" and "dot" as well, because those follow different floating-point rules in the pre-4.0 and the later profiles. (And that has implications for whether you can e.g. fold "0.0 * x" to "0.0" without additional information or not.)
I'm tentatively willing to call that a minor enough difference to justify not splitting that up. At least it seems to me more minor than the difference between discard_nz and texkill, or D3DCOLORtoUBYTE4...