Re: [PATCH v2 0/1] MR2498: msado15: Implement _Recordset Find

[Zebediah Figura (＠zfigura)]

Zebediah Figura (@zfigura) commented about dlls/msado15/recordset.c:
> - filters = LIST_ENTRY(list_head(&recordset->filters), struct column_filter, entry);
> - field_get_Type(recordset->fields->field[filters->column], &datatype);
> -
> - recordset->index += skip_records;
> - for(; recordset->index < recordset->count; recordset->index++)
> - {
> -
>    found = FALSE;
> -
> -
>    switch(datatype)
> -
>    {
> -
>        case adBSTR:
> -
>        case adWChar:
> -
>        {
> -
>            found = column_match_string(filters->condition,
> -
>                                        V_BSTR(&recordset->data[recordset->index * colcnt + filters->column]),
> -
>                                        V_BSTR(&filters->value));

This wraps awkwardly, and makes me think perhaps that VARIANT could be a local variable.