Re: [PATCH v3 0/1] MR218: vkd3d-shader: Implement GetDimensions().

[Giovanni Mascellani (＠giomasce)]

Giovanni Mascellani (@giomasce) commented about libs/vkd3d-shader/tpf.c:
>  write_sm4_instruction(buffer, &instr);
>
> }
>
> +static void write_sm4_sampleinfo(struct hlsl_ctx *ctx, struct vkd3d_bytecode_buffer *buffer,
> -
>    const struct hlsl_ir_resource_load *load)
>
> +{
> - const struct hlsl_type *resource_type = load->resource.var->data_type;
> - const struct hlsl_deref *resource = &load->resource;
> - const struct hlsl_ir_node *dst = &load->node;
> - struct sm4_instruction instr;
> -
> - memset(&instr, 0, sizeof(instr));
> - instr.opcode = VKD3D_SM4_OP_SAMPLE_INFO;
> - if (dst->data_type->base_type == HLSL_TYPE_UINT)
> -
>    instr.opcode |= VKD3DSI_SAMPLE_INFO_UINT << VKD3D_SM4_INSTRUCTION_FLAGS_SHIFT;

Can we also assert that the base type is either `UINT` or `FLOAT`? Same thing for `resinfo`.