21 Jun
2023
21 Jun
'23
12:09 p.m.
On Wed Jun 21 12:09:40 2023 +0000, Jacek Caban wrote:
Looking closer at this, maybe we should just do that in the parent process. What do you think about something like this? https://gitlab.winehq.org/jacek/wine/-/commit/02faf858eb13d0110cd45cc906614d...
yes for moving it into the parent!
but I wonder if this shouldn't rather be done in kernelbase (instead of ntdll) - adding also the creation of the ad hoc console handles when requested from CreateProces flags, and simply having ntdll pass the console handle around (this would also get rid of the pseudo consoles CONSOLE_ALLOC*) - this would look more symmetrical (everything in kernelbase) and ntdll transparent to it (except for unix console inheritance of course)