On Wed Feb 1 20:37:38 2023 +0000, Paul Gofman wrote:
IMO it is absolutely matter of personal preference whether to prefer enum or #define (minus theoretical issue with 64 bit flags but I don't think we need those here). I always respect the desire of maintainer to see it one way or another in the code they maintain and never argue on that. Of course the things get a bit more complicated when there are two maintainers, but I am sure we can figure something even better, like just return bool flag in this case :)
It definitely depends on the surrounding code, in some cases it might be too obvious anyway, even if you see "DWORD flags", I just wanted to mention that I vastly prefer enums sometimes when I read new code full of flags, it makes it a lot easier to find out which is which—but yes in this case bool is even easier.