On 8/22/22 10:11, Francisco Casas wrote:
Hello,
On 19-08-22 22:05, Zebediah Figura (she/her) wrote:
On 8/19/22 19:28, Francisco Casas wrote:
+static inline unsigned int hlsl_offset_dim_count(enum hlsl_sampler_dim dim)
As long as we don't actually need to use this outside of hlsl.y, I'd mildly prefer to keep it there.
Okay. I wrote it in hlsl.h because of its similarity with hlsl_sampler_dim_count(), but I think it can be moved to hlsl.y because the offset node type's dimx should be enough to access this information afterwards.
I figured as much, but I'd like to avoid static inlines wherever possible. They clutter up the header with more code (that affects all CUs), it's harder to notice when there are no more users, there's more separation between the definition and its uses.